Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use merge_params custom marshaller everywhere #740

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Use merge_params custom marshaller everywhere #740

merged 1 commit into from
Nov 27, 2019

Conversation

lkysow
Copy link
Contributor

@lkysow lkysow commented Nov 27, 2019

A spot was missed where merge_params needs to use the custom struct so
it can be marshalled differently.

(caused runatlantis/atlantis#846)

@lkysow
Use merge_params custom marshaller everywhere
12c055d 
A spot was missed where merge_params needs to use the custom struct so
it can be marshalled differently.
@lkysow lkysow mentioned this pull request Nov 27, 2019
Closed
svanharmelen
svanharmelen approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lkysow!

@svanharmelen svanharmelen merged commit 16a4926 into xanzy:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanharmelen svanharmelen svanharmelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkysow @svanharmelen